feat: disable product tours globally#61243
Merged
Merged
Conversation
Generated-By: PostHog Code Task-Id: f9ed3d91-498d-4677-8dc0-62ecf002ffa1
Contributor
|
Reviews (1): Last reviewed commit: "feat: disable product tours globally" | Re-trigger Greptile |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
|
Size Change: 0 B Total Size: 81.1 MB ℹ️ View Unchanged
|
Contributor
|
🎭 Playwright report · View test results →
These issues are not necessarily caused by your changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Product tours were only disabled during impersonated sessions (
disable_product_tours: window.IMPERSONATED_SESSION). We want them disabled for all sessions in the PostHog app.Changes
Set
disable_product_tours: trueunconditionally inloadPostHogJS.tsx. The neighbouringdisable_surveysandopt_out_capturing_by_defaultoptions remain gated onwindow.IMPERSONATED_SESSION— only product tours are affected.How did you test this code?
I'm an agent. This is a one-line config change; no automated tests were added or run. The change flips the
disable_product_toursinit option from a conditional totrue.Automatic notifications
🤖 Agent context
Authored with PostHog Code (Claude Opus). The user asked to disable product tours in
loadPostHogJS.tsx; the existing option was gated on impersonated sessions, so the change flips it to always-on.Created with PostHog Code