chore(slack_app): drop drained workflow.patched markers in posthog-code Slack mention#61333
Merged
Merged
Conversation
The deprecate_patch call shipped in #60670 (2026-06-01) and every pre-deprecation workflow has long drained — the workflow lifetime caps at ~45 minutes (10-minute activity timeouts plus a 15-minute picker wait), so by now nothing in flight still expects the marker in its history. The billing gate stays in place; we just stop emitting the marker.
The comment is left over from the deprecate_patch era and now points at code that no longer exists. The billing-gate rationale itself still belongs here, so keep that part and trim the rest.
…6-05 patch The patch shipped in #59890 on 2026-05-26 — every pre-patch workflow has long since drained (workflow lifetime caps at ~45 minutes). Swap the gating check for deprecate_patch so the gate runs unconditionally on every new workflow while stragglers still replay deterministically.
…atch The patch shipped in #60249 on 2026-05-29. Every pre-patch workflow has long since drained (workflow lifetime caps at ~45 minutes), so the rules-command branch on the mention workflow is dead code — PostHogCodeSlackMentionCommandWorkflow owns the rules pipeline. handle_posthog_code_rules_command_activity is no longer called by any workflow but remains registered for in-flight stragglers and direct test coverage; clean it up in a follow-up once we are sure nothing else depends on it.
… patch The patch shipped in #57655 on 2026-05-26 (cascade + discovery-agent flow replacing the legacy single-shot select activity). Every pre-patch workflow has long since drained (workflow lifetime caps at ~45 minutes), so swap the gate for deprecate_patch, run the cascade path unconditionally, and drop the legacy else branch. Also remove select_posthog_code_repository_activity — the stub that existed solely to let mid-deploy workflows finish their replay — plus its PostHogCodeSlackRepoDecisionData return type. Update AI_ACTIVITIES and the module-integrity test accordingly.
Contributor
|
Reviews (1): Last reviewed commit: "chore(slack_app): deprecate posthog-code..." | Re-trigger Greptile |
andrewm4894
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Cleanup of drained
workflow.patchedmarkers in the PostHog Code Slack mention workflow.Changes
Drained markers handled in this PR (all introduced ≥5 days ago):
posthog-code-slack-billing-gatedeprecate_patch'd 2026-06-01 (#60670)posthog-code-block-no-personal-github-2026-05deprecate_patchposthog-code-mention-skip-rules-commandPostHogCodeSlackMentionCommandWorkflowowns it now)posthog-code-repo-discovery-agent-2026-05select_posthog_code_repository_activitystub +PostHogCodeSlackRepoDecisionData2026-06-02 patches (
-slack-user-github-,-classify-before-gate-,-command-block-no-personal-github-,-command-user-id-) are left in place — too fresh to retire.handle_posthog_code_rules_command_activityis no longer called by any workflow but stays registered for direct test coverage; deleting it can be a follow-up.How did you test this code?
Manually verified by the author in Slack.
Automated tests run locally:
posthog/temporal/tests/ai/test_module_integrity.py— 13 passed (validatesAI_ACTIVITIESmatches the expected set after droppingselect_posthog_code_repository_activity)posthog/temporal/tests/ai/test_block_missing_user_github.py+products/slack_app/backend/tests/test_guess_repository.py— 68 passed, 1 pre-existing log-capture flake (test_cap_reached_truncates_and_warns) that also fails on master when bundled and passes in isolation; unrelated to this diffAutomatic notifications
🤖 Agent context
Claude Opus 4.7 (1M context) drafted the diff and commits. No other tools.