Skip to content

fix(ci): restore ai_observability trigger for general-purpose temporal worker#61351

Merged
webjunkie merged 1 commit into
masterfrom
fix/ci-restore-ai-observability-temporal-trigger
Jun 3, 2026
Merged

fix(ci): restore ai_observability trigger for general-purpose temporal worker#61351
webjunkie merged 1 commit into
masterfrom
fix/ci-restore-ai-observability-temporal-trigger

Conversation

@webjunkie
Copy link
Copy Markdown
Contributor

Problem

The general-purpose temporal worker's change-detection step in container-images-cd.yml decides whether a code change should rebuild and redeploy that worker. #60228 renamed the subscriptions module path on that same grep -qE line and, in the process, accidentally collapsed ^posthog/temporal/(ai_observability|llm_analytics) down to ^posthog/temporal/llm_analytics — dropping the ai_observability alternative.

The LLM analytics temporal workflows live under posthog/temporal/ai_observability/ (that's where start_temporal_worker.py imports them from). So after #60228, a change touching only posthog/temporal/ai_observability/** no longer matched the filter and stopped triggering a rebuild/redeploy of the general-purpose temporal worker.

Changes

Restore the dropped ai_observability alternative in the general-purpose temporal worker's change filter: ^posthog/temporal/llm_analytics^posthog/temporal/(ai_observability|llm_analytics). One-token change, single line.

The subscriptions-path rename from #60228 is correct and left untouched. Other steps (e.g. the LLM analytics evals worker) already carry the full (ai_observability|llm_analytics) group and are unchanged.

How did you test this code?

Authored by an agent. No automated tests added — this is a one-line CI workflow regex fix. Verified by inspection: the dropped alternative is restored, the git diff against master is exactly one line, and the subscriptions path and all other tokens on the line are unchanged. The regex still parses (balanced parens, valid alternation). Confirmed the general-purpose worker was the only step missing the group; the evals worker step already had it.

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

Docs update

No docs impact — CI workflow change only.

🤖 Agent context

Authored by Claude Code (Opus). The task was scoped to a single regression: #60228's subscriptions-path rename silently narrowed the general-purpose temporal worker's change filter, so changes under posthog/temporal/ai_observability/** stopped triggering its rebuild/redeploy.

Approach: searched the workflow for posthog/temporal/llm_analytics tokens not already inside an (ai_observability|llm_analytics) group, found exactly one (the general-purpose worker step), and restored the alternation there. Left the evals worker step alone since it already had the full group, and deliberately did not touch the subscriptions path rename. Kept the change to a single line to make the regression and the fix easy to verify.

Agent-authored — requires human review.

…l worker

#60228's subscriptions-path rename accidentally dropped the
ai_observability alternative from the general-purpose temporal worker's
change-detection filter, collapsing it from
^posthog/temporal/(ai_observability|llm_analytics) to
^posthog/temporal/llm_analytics. As a result, changes touching only
posthog/temporal/ai_observability/** stopped triggering a
rebuild/redeploy of that worker, even though its LLM analytics workflows
live in that directory. Restore the dropped alternative so those changes
deploy again. The subscriptions path rename from that PR is correct and
left as-is.
Copilot AI review requested due to automatic review settings June 3, 2026 10:35
@assign-reviewers-posthog assign-reviewers-posthog Bot requested a review from a team June 3, 2026 10:35
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Jun 3, 2026

Reviews (1): Last reviewed commit: "fix(ci): restore ai_observability trigge..." | Re-trigger Greptile

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a regression in the container-images-cd.yml change-detection regex so that edits under posthog/temporal/ai_observability/** once again trigger a rebuild/redeploy of the general-purpose Temporal worker.

Changes:

  • Restores the (ai_observability|llm_analytics) alternation in the general-purpose Temporal worker grep -qE filter, which previously only matched llm_analytics.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@webjunkie webjunkie merged commit 7d98310 into master Jun 3, 2026
157 checks passed
@webjunkie webjunkie deleted the fix/ci-restore-ai-observability-temporal-trigger branch June 3, 2026 10:46
@deployment-status-posthog
Copy link
Copy Markdown

deployment-status-posthog Bot commented Jun 3, 2026

Deploy status

Environment Status Deployed At Workflow
dev ✅ Deployed 2026-06-03 11:41 UTC Run
prod-us ✅ Deployed 2026-06-03 12:05 UTC Run
prod-eu ✅ Deployed 2026-06-03 12:09 UTC Run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants