fix(ci): restore ai_observability trigger for general-purpose temporal worker#61351
Merged
webjunkie merged 1 commit intoJun 3, 2026
Merged
Conversation
…l worker #60228's subscriptions-path rename accidentally dropped the ai_observability alternative from the general-purpose temporal worker's change-detection filter, collapsing it from ^posthog/temporal/(ai_observability|llm_analytics) to ^posthog/temporal/llm_analytics. As a result, changes touching only posthog/temporal/ai_observability/** stopped triggering a rebuild/redeploy of that worker, even though its LLM analytics workflows live in that directory. Restore the dropped alternative so those changes deploy again. The subscriptions path rename from that PR is correct and left as-is.
Contributor
|
Reviews (1): Last reviewed commit: "fix(ci): restore ai_observability trigge..." | Re-trigger Greptile |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a regression in the container-images-cd.yml change-detection regex so that edits under posthog/temporal/ai_observability/** once again trigger a rebuild/redeploy of the general-purpose Temporal worker.
Changes:
- Restores the
(ai_observability|llm_analytics)alternation in the general-purpose Temporal workergrep -qEfilter, which previously only matchedllm_analytics.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
k33lan
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The general-purpose temporal worker's change-detection step in
container-images-cd.ymldecides whether a code change should rebuild and redeploy that worker. #60228 renamed the subscriptions module path on that samegrep -qEline and, in the process, accidentally collapsed^posthog/temporal/(ai_observability|llm_analytics)down to^posthog/temporal/llm_analytics— dropping theai_observabilityalternative.The LLM analytics temporal workflows live under
posthog/temporal/ai_observability/(that's wherestart_temporal_worker.pyimports them from). So after #60228, a change touching onlyposthog/temporal/ai_observability/**no longer matched the filter and stopped triggering a rebuild/redeploy of the general-purpose temporal worker.Changes
Restore the dropped
ai_observabilityalternative in the general-purpose temporal worker's change filter:^posthog/temporal/llm_analytics→^posthog/temporal/(ai_observability|llm_analytics). One-token change, single line.The subscriptions-path rename from #60228 is correct and left untouched. Other steps (e.g. the LLM analytics evals worker) already carry the full
(ai_observability|llm_analytics)group and are unchanged.How did you test this code?
Authored by an agent. No automated tests added — this is a one-line CI workflow regex fix. Verified by inspection: the dropped alternative is restored, the
git diffagainst master is exactly one line, and the subscriptions path and all other tokens on the line are unchanged. The regex still parses (balanced parens, valid alternation). Confirmed the general-purpose worker was the only step missing the group; the evals worker step already had it.Automatic notifications
Docs update
No docs impact — CI workflow change only.
🤖 Agent context
Authored by Claude Code (Opus). The task was scoped to a single regression: #60228's subscriptions-path rename silently narrowed the general-purpose temporal worker's change filter, so changes under
posthog/temporal/ai_observability/**stopped triggering its rebuild/redeploy.Approach: searched the workflow for
posthog/temporal/llm_analyticstokens not already inside an(ai_observability|llm_analytics)group, found exactly one (the general-purpose worker step), and restored the alternation there. Left the evals worker step alone since it already had the full group, and deliberately did not touch the subscriptions path rename. Kept the change to a single line to make the regression and the fix easy to verify.Agent-authored — requires human review.