Conversation
gewenyu99
left a comment
gewenyu99
left a comment
There was a problem hiding this comment.
Discussion on submodules but lgtm otherwise
There was a problem hiding this comment.
Solid, I wonder if we should use more submodules. I've intentionally deleted git from many example projects because I've generally found it annoying to work with a bunch of submodules, but maybe this is the way.
@PostHog/team-docs-wizard thoughts on this?
There was a problem hiding this comment.
It is mildly annoying, I agree, literally don't understand why it isn't a bigger first class citizen, but I also felt like it was worth trying!
There was a problem hiding this comment.
Yah definitely down to try this, is probably cleaner :D
There was a problem hiding this comment.
I think it's the future, but just paranoid around footguns for UX and CI pipelines. It's probably okay
|
Also :pog: for using a real basecamp app |
3 participants
Let's go!
tested it locally and it's working very well, I really like it actually. It was also very fast, and properly detected the versions, etc.
I'm using https://github.com/basecamp/fizzy as our example app. It's a submodule rather than a copy, how do you feel about that @PostHog/team-docs-wizard ?