Skip to content

fix: use /sse for cursor#121

Merged
joshsny merged 2 commits intomainfrom
sse-cursor
Aug 19, 2025
Merged

fix: use /sse for cursor#121
joshsny merged 2 commits intomainfrom
sse-cursor

Conversation

@joshsny
Copy link
Copy Markdown
Collaborator

@joshsny joshsny commented Aug 19, 2025

Cursor isn't vibing well with the Streamable HTTP endpoint, so this moves it over to the /sse endpoint

@joshsny joshsny requested review from Copilot and jonathanlab and removed request for Copilot August 19, 2025 13:13
@jonathanlab
Copy link
Copy Markdown
Collaborator

jonathanlab commented Aug 19, 2025

Will also update our docs accordingly. Is it only Cursor that doesn't play nice with the Streamable HTTP ecosystem?

Copilot AI review requested due to automatic review settings August 19, 2025 13:19
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes compatibility issues between Cursor and the Streamable HTTP endpoint by switching Cursor to use the SSE (Server-Sent Events) endpoint instead.

  • Adds a configurable server type parameter to support both SSE and Streamable HTTP endpoints
  • Updates Cursor client to specifically use the SSE endpoint
  • Maintains backward compatibility for other clients that continue using Streamable HTTP

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/steps/add-mcp-server-to-clients/defaults.ts Adds MCPServerType and updates getDefaultServerConfig to accept endpoint type parameter
src/steps/add-mcp-server-to-clients/clients/cursor.ts Overrides addServer method to use SSE endpoint specifically for Cursor
src/steps/add-mcp-server-to-clients/MCPClient.ts Refactors addServer to use new _addServerType method with configurable endpoint type
src/steps/add-mcp-server-to-clients/clients/tests/claude.test.ts Updates test to verify Claude continues using streamable-http endpoint

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@joshsny
Copy link
Copy Markdown
Collaborator Author

joshsny commented Aug 19, 2025

Will also update our docs accordingly. Is it only Cursor that doesn't play nice with the Streamable HTTP ecosystem?

Going to test out the others and then can do a batch update to docs 👍

@joshsny joshsny enabled auto-merge (squash) August 19, 2025 13:20
@joshsny joshsny merged commit 1b942a4 into main Aug 19, 2025
10 checks passed
daniloc pushed a commit that referenced this pull request Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants