Conversation
Collaborator
|
Will also update our docs accordingly. Is it only Cursor that doesn't play nice with the Streamable HTTP ecosystem? |
jonathanlab
approved these changes
Aug 19, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes compatibility issues between Cursor and the Streamable HTTP endpoint by switching Cursor to use the SSE (Server-Sent Events) endpoint instead.
- Adds a configurable server type parameter to support both SSE and Streamable HTTP endpoints
- Updates Cursor client to specifically use the SSE endpoint
- Maintains backward compatibility for other clients that continue using Streamable HTTP
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/steps/add-mcp-server-to-clients/defaults.ts | Adds MCPServerType and updates getDefaultServerConfig to accept endpoint type parameter |
| src/steps/add-mcp-server-to-clients/clients/cursor.ts | Overrides addServer method to use SSE endpoint specifically for Cursor |
| src/steps/add-mcp-server-to-clients/MCPClient.ts | Refactors addServer to use new _addServerType method with configurable endpoint type |
| src/steps/add-mcp-server-to-clients/clients/tests/claude.test.ts | Updates test to verify Claude continues using streamable-http endpoint |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Collaborator
Author
Going to test out the others and then can do a batch update to docs 👍 |
daniloc
pushed a commit
that referenced
this pull request
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cursor isn't vibing well with the Streamable HTTP endpoint, so this moves it over to the /sse endpoint