Skip to content

Comments

fix: django detection bug#258

Merged
sarahxsanders merged 2 commits intomainfrom
django-detection-bug
Feb 5, 2026
Merged

fix: django detection bug#258
sarahxsanders merged 2 commits intomainfrom
django-detection-bug

Conversation

@sarahxsanders
Copy link
Contributor

Django detection was too broad (my b!!!) and caused false positives - for example, it would detect a file with "print('Hello from my-django-app')" as a Django project

fix:

  • checks actual Django imports, patterns, and uses regex to match package declarations

testing:

  • tested with edge cases I created for basic python skill. made a fake django app (manage.py w/ no imports) and a real django app
  • verified after this fix it doesn't detect Django in the fake Django app

@sarahxsanders sarahxsanders requested a review from a team February 5, 2026 21:55
@github-actions
Copy link

github-actions bot commented Feb 5, 2026

🧙 Wizard CI

Run the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands:

Test all apps:

  • /wizard-ci all

Test all apps in a directory:

  • /wizard-ci django
  • /wizard-ci flask
  • /wizard-ci laravel
  • /wizard-ci next-js
  • /wizard-ci react-router
  • /wizard-ci tanstack-router
  • /wizard-ci tanstack-start

Test an individual app:

  • /wizard-ci django/django3-saas
  • /wizard-ci flask/flask3-social-media
  • /wizard-ci laravel/laravel12-saas
Show more apps
  • /wizard-ci next-js/15-app-router-saas
  • /wizard-ci next-js/15-app-router-todo
  • /wizard-ci next-js/15-pages-router-saas
  • /wizard-ci next-js/15-pages-router-todo
  • /wizard-ci react-router/react-router-v7-project
  • /wizard-ci react-router/rrv7-starter
  • /wizard-ci react-router/saas-template
  • /wizard-ci react-router/shopper
  • /wizard-ci tanstack-router/tanstack-router-code-based-saas
  • /wizard-ci tanstack-router/tanstack-router-file-based-saas
  • /wizard-ci tanstack-start/tanstack-start-saas

Results will be posted here when complete.

Copy link
Member

@edwinyjlim edwinyjlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sarahxsanders sarahxsanders enabled auto-merge (squash) February 5, 2026 22:15
@sarahxsanders sarahxsanders merged commit 368d89f into main Feb 5, 2026
14 checks passed
@sarahxsanders sarahxsanders deleted the django-detection-bug branch February 5, 2026 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants