fix(mcp): drop /sse transport, always install /mcp#429
Merged
posthog[bot] merged 2 commits intomainfrom Apr 30, 2026
Merged
Conversation
The MCP server no longer serves /sse, so installs that pointed there (Claude Desktop default + leftover client overrides) were broken. Remove the sse | streamable-http abstraction entirely — there's only one transport now. Generated-By: PostHog Code Task-Id: f63629de-019f-44ee-bf68-c3c8a15570f3
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Results will be posted here when complete. |
Collaborator
|
I think there are a few loose instances of SSE in docs still 👀 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the obsolete MCP transport-type abstraction now that the PostHog MCP server no longer serves /sse, ensuring generated client configs always point to /mcp.
Changes:
- Simplifies URL/config builders (
buildMCPUrl,getNativeHTTPServerConfig,getDefaultServerConfig) to always emit/mcpand removes the transport-type parameter. - Deletes client-specific
addServeroverrides that only existed to force'streamable-http'. - Updates Jest fixtures to match the new function signatures and
/mcpdefaults.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/steps/add-mcp-server-to-clients/defaults.ts | Removes transport-type arg; always builds /mcp URLs and derived configs. |
| src/steps/add-mcp-server-to-clients/MCPClient.ts | Removes transport threading from default install path; always uses new default config builder. |
| src/steps/add-mcp-server-to-clients/clients/cursor.ts | Updates Cursor config generation to new getNativeHTTPServerConfig signature. |
| src/steps/add-mcp-server-to-clients/clients/zed.ts | Removes transport arg usage and deletes now-unnecessary addServer override. |
| src/steps/add-mcp-server-to-clients/clients/visual-studio-code.ts | Removes transport arg usage and deletes now-unnecessary addServer override. |
| src/steps/add-mcp-server-to-clients/clients/tests/claude.test.ts | Updates expectations for new getDefaultServerConfig call shape. |
| src/steps/add-mcp-server-to-clients/tests/defaults.test.ts | Updates defaults tests to reflect /mcp and new signatures. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The Copilot review caught that ZedClient and VisualStudioCodeClient
unconditionally wrote Authorization: Bearer ${apiKey}, which would emit
"Bearer undefined" when invoked in OAuth mode (DefaultMCPClient.addServer
passes apiKey?: string).
Reuse getNativeHTTPServerConfig — same pattern Cursor uses — so the auth
header is only emitted when an API key is present.
Generated-By: PostHog Code
Task-Id: cce4f29c-186a-4e54-9019-bbd0f2be0c28
edwinyjlim
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/sse, so any installation pointing there is broken. Two paths still did:DefaultMCPClient.addServer(inherited by Claude Desktop) and a now-stale Codex callsite (Codex itself moved to plugin install, but the'sse' | 'streamable-http'abstraction was still threaded through the codebase).buildMCPUrl,getNativeHTTPServerConfig, andgetDefaultServerConfigno longer take atypearg and always emit/mcp. Cursor / VS Code / ZedaddServeroverrides existed solely to pass'streamable-http'and are now unnecessary — deleted.'sse'is the Zod enum atvisual-studio-code.ts:19that parses VS Code's ownmcp.json— left untouched so we don't reject existing user configs.Test plan
pnpm exec jest— 589 pass (updateddefaults.test.tsandclaude.test.tsfixtures to drop thetypearg).pnpm typecheckclean withinsrc/steps/add-mcp-server-to-clients.--localagainst Claude Desktop and verify the written config points athttp://localhost:8787/mcp.Created with PostHog Code