Skip to content

Add test/CLAUDE.md referencing ai/'s schema-testing conventions - #58

Merged
jnasbyupgrade merged 1 commit into
Postgres-Extensions:masterfrom
jnasbyupgrade:add-schema-test-doc
Aug 9, 2026
Merged

Add test/CLAUDE.md referencing ai/'s schema-testing conventions#58
jnasbyupgrade merged 1 commit into
Postgres-Extensions:masterfrom
jnasbyupgrade:add-schema-test-doc

Conversation

@jnasbyupgrade

Copy link
Copy Markdown
Contributor

This extension isn't pinned to a fixed schema (no schema= in its .control file, and its install SQL uses @extschema@ throughout), so Postgres-Extensions/ai's random-schema testing conventions (ai#5) apply here.

This extension isn't pinned to a fixed schema (no schema= in its
.control file, and its install SQL uses @extschema@ throughout), so the
random-schema testing conventions apply here.
@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 09e72b25-b057-4e48-a7ef-d24c32bc9190

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown

Claude finished @jnasbyupgrade's task in 1m 39s —— View job


Code Review: Add test/CLAUDE.md

  • Gather context (read PR diff, referenced conventions)
  • Understand the request
  • Review the change
  • Post final review

Summary: This is a 5-line, doc-only PR that adds test/CLAUDE.md, pointing readers to ../../ai/test/CLAUDE.md (schema/search_path-isolation principle) and ../../ai/RANDOM_SCHEMA_TESTING.md (random-schema testing conventions) in the sibling Postgres-Extensions/ai repo.

Verified against this repo:

  • count_nulls.control has no schema= line — confirmed.
  • ✅ Install scripts (sql/count_nulls.sql, sql/count_nulls--1.0.0.sql, sql/count_nulls--stable.sql) each use @extschema@ 4 times — confirmed. So the stated rationale for applying the random-schema testing conventions holds.
  • ✅ Relative path math is correct: from test/CLAUDE.md, ../../ai/... resolves to the same location as ../ai/... from the root CLAUDE.md (one extra ../ to account for being one directory deeper).
  • ✅ Style/wrapping is consistent with the existing root CLAUDE.md.

Minor observation (non-blocking): The root CLAUDE.md includes a fallback (the GitHub URL + "clone it to ../ai/ per its own first instruction") for when the ../ai/ path doesn't exist locally. The new test/CLAUDE.md doesn't repeat that fallback, but since it's colocated with the root file which already establishes the clone convention, this is a reasonable omission to avoid redundancy — not a real issue.

Not verified: I don't have network/API access in this session, so I could not confirm that test/CLAUDE.md and RANDOM_SCHEMA_TESTING.md actually exist at those paths in Postgres-Extensions/ai, or that issue ai#5 matches the description in the PR body. Given the author's context and the accurate description of this repo's @extschema@/schema-less setup, I have no reason to doubt it, but a maintainer familiar with the ai repo should give it a quick sanity check.

Verdict: LGTM — low-risk, accurate, and consistent documentation addition.

@jnasbyupgrade
jnasbyupgrade merged commit 827473b into Postgres-Extensions:master Aug 9, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant