docs: no Testing section in PR descriptions unless CI can't cover it#36
Merged
jnasbyupgrade merged 1 commit intoJul 26, 2026
Merged
Conversation
Standard is to rely on CI. Only add a Testing/Test plan section when something needs verification CI won't provide (manual step, a live trigger that can't run in CI, a known limitation worth flagging). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jnasbyupgrade
marked this pull request as ready for review
July 26, 2026 21:10
jnasbyupgrade
merged commit Jul 26, 2026
4ce0d67
into
Postgres-Extensions:master
9 of 10 checks passed
jnasbyupgrade
added a commit
that referenced
this pull request
Jul 26, 2026
Related pgxntool PR: Postgres-Extensions/pgxntool#71 Adds PostgreSQL 18 to `run-tests.yml`'s test matrix. Also adds a doc-only bypass to `ci.yml`'s `resolve` job: when every changed file in a PR is pure documentation (`*.md`, `*.asc`, `*.adoc`, `*.asciidoc`, anywhere including `.claude/`, but never under `.github/` — workflow definitions carry real behavioral weight regardless of extension), the `test` job is skipped entirely. Surfaced by PR #36 (a pure `.claude/commands/pr.md` doc change) running the full Postgres test matrix unnecessarily. `claude-review` is unaffected (separate workflow, own gate) and still runs. Fixes Postgres-Extensions/pgxntool#62. --------- Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codifies existing practice in /pr's PR Description Guidelines: rely on CI by default, and only add a Testing/Test plan section when something needs verification CI won't provide (a manual step, a live trigger that can't run in CI, a known limitation worth flagging).