Skip to content

CI: applying commit-with-no-tests doesn't re-trigger the check (PR stays red) #64

Description

@jnasbyupgrade

Problem

`.github/workflows/ci.yml` triggers on:

```yaml
on:
pull_request:
```

With no explicit `types:`, this defaults to `[opened, synchronize, reopened]` — it does not include `labeled`. So when a maintainer applies the `commit-with-no-tests` label to unblock a PR that genuinely has no paired pgxntool-test PR, nothing re-triggers `check-test-pr`. The PR keeps showing the earlier failed run (from before the label was applied) until someone pushes a new commit or manually re-runs the job via the Actions UI / `gh run rerun`.

This makes the `commit-with-no-tests` escape hatch confusing in practice: a maintainer applies the label expecting it to unblock the PR, but the PR still shows red with no obvious next step.

Proposal

Add `labeled`/`unlabeled` to the `pull_request` `types:` list in `ci.yml` so applying/removing the label re-runs `check-test-pr` automatically and picks up the new label state. Needs a check that this doesn't also cause unwanted re-runs from unrelated label activity (e.g. other labels like `bug`/`enhancement` shouldn't trigger a re-run — may need an early exit in the job, or scope the trigger more precisely if GitHub Actions doesn't support per-label trigger filtering).

Related

Related to #62 (doc-only PRs should be automatically exempt from the pairing requirement in the first place, which would reduce how often the label — and this problem — comes up at all).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions