Fix make pgtle PGTLE_VERSION=X being silently ignored - #66
Merged
jnasbyupgrade merged 2 commits intoJul 26, 2026
Merged
Conversation
…sions#65) base.mk's pgtle target never forwarded the PGTLE_VERSION make variable to pgtle.sh's --pgtle-version flag, so `make pgtle PGTLE_VERSION=1.5.0+` generated all three version ranges instead of just the one requested, despite this being the documented usage in CLAUDE.md. Related changes in pgxntool-test: - Added a BATS test asserting `make pgtle PGTLE_VERSION=1.5.0+` only generates the requested version range's output file Co-Authored-By: Claude <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jnasbyupgrade
marked this pull request as ready for review
July 26, 2026 21:06
…rsion-makefile # Conflicts: # HISTORY.asc
jnasbyupgrade
added a commit
to Postgres-Extensions/pgxntool-test
that referenced
this pull request
Jul 26, 2026
- Companion test for Postgres-Extensions/pgxntool#66, which fixes `make pgtle PGTLE_VERSION=X` being silently ignored (issue pgxntool#65). - Added a BATS test in `test/sequential/04-pgtle.bats` asserting `make pgtle PGTLE_VERSION=1.5.0+` generates only the requested version range's output file, not all three. - Clarified the neighboring test's comment, which previously noted the Makefile path didn't work — it's now covered too. - Verified the new test reproduces the failure against unfixed `pgtle` before pulling in the fix. --------- Co-authored-by: Claude <noreply@anthropic.com>
jnasbyupgrade
merged commit Jul 26, 2026
3b0e3de
into
Postgres-Extensions:master
5 of 6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
base.mk'spgtletarget never forwarded thePGTLE_VERSIONmake variable topgtle.sh --pgtle-version, somake pgtle PGTLE_VERSION=1.5.0+silently generated all three version ranges instead of the one requested — despite this being the documented usage in CLAUDE.md.--pgtle-version $(PGTLE_VERSION)through when the variable is set.STABLEHISTORY.asc entry.pgtlebefore applying this fix.Closes #65.
Companion pgxntool-test PR: Postgres-Extensions/pgxntool-test#32