auth lmdb: correctly update timestamps in non-split domain table mode#17516
Open
miodvallat wants to merge 3 commits into
Open
auth lmdb: correctly update timestamps in non-split domain table mode#17516miodvallat wants to merge 3 commits into
miodvallat wants to merge 3 commits into
Conversation
Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>
pieterlexis
reviewed
Jun 4, 2026
Contributor
pieterlexis
left a comment
pieterlexis
left a comment
There was a problem hiding this comment.
A (unit?)test to prevent regressions would be good
Coverage Report for CI Build 26952964725Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage increased (+0.03%) to 71.115%Details
Uncovered Changes
Coverage Regressions107 previously-covered lines in 14 files lost coverage.
Coverage Stats
💛 - Coveralls |
Contributor
Author
Indeed. The hardest part was finding where to put it; hopefully this won't break CI. |
miodvallat
force-pushed
the
brainless
branch
3 times, most recently
from
760eb69 to
2e75702
Compare
Contributor
Author
|
Can't get the CI to pass ATM, removing the test, will do it in a separate PR |
Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>
Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
This is an embarassing bug which is tarnishing the 5.1 release. As noticed by @mind04, an lmdb database configured with the defaults (write notification update timestamps immediately, and domain table not split) will fail to actually write these timestamps.
Possible workaround are to enable split domain table (but will not be interoperable with older versions lacking the feature), or disable writes and perform regular flushes with pdns_control.
Checklist
I have: