Skip to content

auth lmdb: correctly update timestamps in non-split domain table mode#17523

Open
miodvallat wants to merge 4 commits into
PowerDNS:masterfrom
miodvallat:morebrainless
Open

auth lmdb: correctly update timestamps in non-split domain table mode#17523
miodvallat wants to merge 4 commits into
PowerDNS:masterfrom
miodvallat:morebrainless

Conversation

@miodvallat
Copy link
Copy Markdown
Contributor

Short description

This is on top of #17516, and adds a crude check which appears to pass CI now.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • read and accepted the Developer Certificate of Origin document, including the AI Policy, and added a "Signed-off-by" to my commits
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>
Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>
Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>
Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>
@miodvallat miodvallat added the auth label Jun 4, 2026
@coveralls
Copy link
Copy Markdown

Coverage Report for CI Build 26956094536

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Coverage increased (+0.02%) to 71.085%

Details

  • Coverage increased (+0.02%) from the base build.
  • Patch coverage: 5 uncovered changes across 1 file (11 of 16 lines covered, 68.75%).
  • 19 coverage regressions across 9 files.

Uncovered Changes

File Changed Covered %
modules/lmdbbackend/lmdbbackend.cc 16 11 68.75%

Coverage Regressions

19 previously-covered lines in 9 files lost coverage.

File Lines Losing Coverage Coverage
pdns/recursordist/rec-tcpout.cc 5 79.05%
pdns/misc.cc 4 61.67%
pdns/auth-secondarycommunicator.cc 2 57.89%
pdns/recursordist/recpacketcache.cc 2 83.14%
pdns/recursordist/syncres.cc 2 81.22%
pdns/dnsdistdist/dnsdist-tcp.cc 1 74.49%
pdns/packethandler.cc 1 69.12%
pdns/recursordist/aggressive_nsec.cc 1 66.27%
pdns/signingpipe.cc 1 83.16%

Coverage Stats

Coverage Status
Relevant Lines: 170718
Covered Lines: 132967
Line Coverage: 77.89%
Relevant Branches: 81542
Covered Branches: 46352
Branch Coverage: 56.84%
Branches in Coverage %: Yes
Coverage Strength: 6183350.03 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants