Backport 17786 to rec 5.2.x: fix disabling algo 8 also disables DS digest 2 - #17845
Merged
omoerbeek merged 1 commit intoAug 3, 2026
Merged
Conversation
Fixes PowerDNS#17772 in a quick and dirty way. Proper fix should separate algo handling and digest handling, as more than one algo can use the same digest. Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com> (cherry picked from commit fe26a25)
miodvallat
approved these changes
Aug 3, 2026
Coverage Report for CI Build 30795283517Coverage increased (+0.01%) to 66.734%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions23 previously-covered lines in 8 files lost coverage.
Coverage Stats💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17772 in a quick and dirty way.
Proper fix should separate algo handling and digest handling, as more than one algo can use the same digest.
(cherry picked from commit fe26a25)
Backport of #17786
Short description
Checklist
I have: