Skip to content

Backport 17786 to rec 5.2.x: fix disabling algo 8 also disables DS digest 2 - #17845

Merged
omoerbeek merged 1 commit into
PowerDNS:rel/rec-5.2.xfrom
omoerbeek:backport-17786-to-rec-5.2.x
Aug 3, 2026
Merged

Backport 17786 to rec 5.2.x: fix disabling algo 8 also disables DS digest 2#17845
omoerbeek merged 1 commit into
PowerDNS:rel/rec-5.2.xfrom
omoerbeek:backport-17786-to-rec-5.2.x

Conversation

@omoerbeek

@omoerbeek omoerbeek commented Aug 3, 2026

Copy link
Copy Markdown
Member

Fixes #17772 in a quick and dirty way.

Proper fix should separate algo handling and digest handling, as more than one algo can use the same digest.

(cherry picked from commit fe26a25)

Backport of #17786

Short description

Checklist

I have:

  • read the CONTRIBUTING.md document
  • read and accepted the Developer Certificate of Origin document, including the AI Policy, and added a "Signed-off-by" to my commits
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

Fixes PowerDNS#17772 in a quick and dirty way.

Proper fix should separate algo handling and digest handling, as
more than one algo can use the same digest.

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
(cherry picked from commit fe26a25)
@omoerbeek omoerbeek added this to the rec-5.2.x milestone Aug 3, 2026
@omoerbeek omoerbeek changed the title Backport 17786 to rec 5.3.x: fix disabling algo 8 also disables DS digest 2 Backport 17786 to rec 5.2.x: fix disabling algo 8 also disables DS digest 2 Aug 3, 2026
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 30795283517

Coverage increased (+0.01%) to 66.734%

Details

  • Coverage increased (+0.01%) from the base build.
  • Patch coverage: 3 of 3 lines across 1 file are fully covered (100%).
  • 23 coverage regressions across 8 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

23 previously-covered lines in 8 files lost coverage.

File Lines Losing Coverage Coverage
pdns/recursordist/test-syncres_cc1.cc 5 89.71%
pdns/opensslsigners.cc 3 57.4%
pdns/recursordist/pdns_recursor.cc 3 73.6%
pdns/recursordist/syncres.cc 3 80.06%
pdns/recursordist/test-syncres_cc2.cc 3 88.85%
pdns/remote_logger.cc 3 53.13%
pdns/recursordist/aggressive_nsec.cc 2 67.03%
pdns/dnssecinfra.cc 1 54.73%

Coverage Stats

Coverage Status
Relevant Lines: 78098
Covered Lines: 58797
Line Coverage: 75.29%
Relevant Branches: 36008
Covered Branches: 17350
Branch Coverage: 48.18%
Branches in Coverage %: Yes
Coverage Strength: 4111937.86 hits per line

💛 - Coveralls

@omoerbeek
omoerbeek merged commit 2627c0c into PowerDNS:rel/rec-5.2.x Aug 3, 2026
44 checks passed
@omoerbeek
omoerbeek deleted the backport-17786-to-rec-5.2.x branch August 3, 2026 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants