Skip to content

Backport 17797 to rec 5.2.x: Account for the existing content when parsing labels - #17849

Merged
omoerbeek merged 3 commits into
PowerDNS:rel/rec-5.2.xfrom
omoerbeek:backport-17818-to-rec-5.2.x
Aug 3, 2026
Merged

Backport 17797 to rec 5.2.x: Account for the existing content when parsing labels#17849
omoerbeek merged 3 commits into
PowerDNS:rel/rec-5.2.xfrom
omoerbeek:backport-17818-to-rec-5.2.x

Conversation

@omoerbeek

Copy link
Copy Markdown
Member

Short description

Backport of #17797 and #17790

Checklist

I have:

  • read the CONTRIBUTING.md document
  • read and accepted the Developer Certificate of Origin document, including the AI Policy, and added a "Signed-off-by" to my commits
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit 8fe9bc6)
(cherry picked from commit c3742bd)
Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit 0a1d081)
(cherry picked from commit 5064be0)
Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit 77a8a2e)
(cherry picked from commit cdbec41)
@omoerbeek omoerbeek added this to the rec-5.2.x milestone Aug 3, 2026
@omoerbeek omoerbeek added the rec label Aug 3, 2026
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 30798741501

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Coverage increased (+0.005%) to 66.727%

Details

  • Coverage increased (+0.005%) from the base build.
  • Patch coverage: 2 uncovered changes across 1 file (13 of 15 lines covered, 86.67%).
  • 26 coverage regressions across 6 files.

Uncovered Changes

File Changed Covered %
pdns/dnsname.cc 7 5 71.43%
Total (2 files) 15 13 86.67%

Coverage Regressions

26 previously-covered lines in 6 files lost coverage.

File Lines Losing Coverage Coverage
pdns/recursordist/test-syncres_cc1.cc 13 89.28%
pdns/recursordist/syncres.cc 4 79.83%
pdns/opensslsigners.cc 3 57.47%
pdns/recursordist/pdns_recursor.cc 3 73.51%
pdns/recursordist/aggressive_nsec.cc 2 67.03%
pdns/dnssecinfra.cc 1 54.62%

Coverage Stats

Coverage Status
Relevant Lines: 78109
Covered Lines: 58813
Line Coverage: 75.3%
Relevant Branches: 36012
Covered Branches: 17336
Branch Coverage: 48.14%
Branches in Coverage %: Yes
Coverage Strength: 4879949.19 hits per line

💛 - Coveralls

@omoerbeek
omoerbeek merged commit b1bd94f into PowerDNS:rel/rec-5.2.x Aug 3, 2026
155 of 161 checks passed
@omoerbeek
omoerbeek deleted the backport-17818-to-rec-5.2.x branch August 3, 2026 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants