Skip to content

Backport 17835 to rec-5.2.x: do not index past the address for byte-aligned prefixes - #17852

Merged
omoerbeek merged 1 commit into
PowerDNS:rel/rec-5.2.xfrom
omoerbeek:backport-17835-to-rec-5.2.x
Aug 3, 2026
Merged

Backport 17835 to rec-5.2.x: do not index past the address for byte-aligned prefixes#17852
omoerbeek merged 1 commit into
PowerDNS:rel/rec-5.2.xfrom
omoerbeek:backport-17835-to-rec-5.2.x

Conversation

@omoerbeek

Copy link
Copy Markdown
Member

(cherry picked from commit 9e2edcf)

Backport of #17835

Short description

Checklist

I have:

  • read the CONTRIBUTING.md document
  • read and accepted the Developer Certificate of Origin document, including the AI Policy, and added a "Signed-off-by" to my commits
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

Signed-off-by: Itecz Solution <support@itecz.au>
(cherry picked from commit 9e2edcf)
@omoerbeek omoerbeek added this to the rec-5.2.x milestone Aug 3, 2026
@omoerbeek omoerbeek added the rec label Aug 3, 2026
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 30799697863

Coverage decreased (-0.005%) to 66.731%

Details

  • Coverage decreased (-0.005%) from the base build.
  • Patch coverage: 22 of 22 lines across 3 files are fully covered (100%).
  • 56 coverage regressions across 11 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

56 previously-covered lines in 11 files lost coverage.

Top 10 Files by Coverage Loss Lines Losing Coverage Coverage
pdns/recursordist/rec-tcp.cc 10 68.22%
pdns/recursordist/syncres.cc 10 79.86%
pdns/recursordist/ext/luawrapper/include/LuaContext.hpp 8 14.15%
pdns/recursordist/rec-tcpout.cc 6 50.79%
pdns/recursordist/test-syncres_cc1.cc 6 89.74%
pdns/recursordist/pdns_recursor.cc 5 73.63%
pdns/misc.cc 3 39.93%
pdns/recursordist/test-syncres_cc2.cc 3 88.91%
pdns/iputils.hh 2 68.63%
pdns/recursordist/lwres.cc 2 70.25%

Coverage Stats

Coverage Status
Relevant Lines: 78121
Covered Lines: 58820
Line Coverage: 75.29%
Relevant Branches: 36012
Covered Branches: 17342
Branch Coverage: 48.16%
Branches in Coverage %: Yes
Coverage Strength: 3668881.07 hits per line

💛 - Coveralls

@omoerbeek
omoerbeek merged commit 72562a4 into PowerDNS:rel/rec-5.2.x Aug 3, 2026
81 of 83 checks passed
@omoerbeek
omoerbeek deleted the backport-17835-to-rec-5.2.x branch August 3, 2026 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants