[Fix] correctly handle dates in function parameters#446
Merged
Power-Maverick merged 1 commit intoMar 9, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes incorrect handling of date parameters when invoking Dataverse function APIs. When a Date object is passed as a function parameter, the formatFunctionParameter method now detects it via instanceof Date and converts it to an ISO string before URL construction. Without this, the date would fall through to the generic object path and be JSON-serialized with surrounding double-quotes, which Dataverse rejects.
Changes:
- Adds an
instanceof Datebranch informatFunctionParameter(inDataverseManager) that converts aDateto its ISO string representation before it is embedded in the OData function URL query string.
Power-Maverick
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently date parameters are not well resolved in function execution.
If a date parameter is sent in a function call, we receive an error like this.
Custom API 'driv_FuncApi' execution failed: Error invoking remote method 'dataverse.execute': Error: Dataverse execute failed: 0x80060888: Syntax error: character '"' is not valid at position 0 in '"2026-03-04T05:00:00.000Z"'.
This PR correctly handles date parameters by converting them appropriately
In method formatFunctionParameter of DataverseManager