Add link to .NET CLI version in build documentation#11725
Merged
iSazonov merged 2 commits intoPowerShell:masterfrom Jan 31, 2020
Merged
Add link to .NET CLI version in build documentation#11725iSazonov merged 2 commits intoPowerShell:masterfrom
iSazonov merged 2 commits intoPowerShell:masterfrom
Conversation
Fix .NET CLI version
ghost
assigned
iSazonov
reviewed
Jan 30, 2020
docs/building/windows-core.md
Outdated
|
|
||
| We use the [.NET Command Line Interface][dotnet-cli] (`dotnet`) to build PowerShell. | ||
| The version we are currently using is `3.0.0`. | ||
| The version we are currently using is mentionned in [`global.json`](../../global.json#L3) at the root of this repository. |
Collaborator
There was a problem hiding this comment.
Please use absolute path.
Contributor
Author
There was a problem hiding this comment.
What do you mean by absolute path? https://github.com/PowerShell/PowerShell/blob/master/global.json?
I don't think that's a good practice.
iSazonov
added
the
CL-Docs
iSazonov
approved these changes
Jan 31, 2020
iSazonov
changed the title
Collaborator
|
@joeltankam Thanks for your contribution. |
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix .NET CLI version