Revert "Enhance Remove-Item to work with OneDrive (#14902)"

[TravisEz13]

PR Summary

We have been having issues with Remove-Item -Recure -Force failing since fafc38f.

So, reverting that commit until the issue has been addressed.

PR Context

https://dev.azure.com/powershell/PowerShell/_build/results?buildId=76645&view=logs&j=719313b2-5d75-51d7-9f16-928d568dcba1&t=51cacb73-0bf2-5113-ddc2-bada8ccfae1e&l=114

Tests were failing with:

 Describing About help files can be found in AllUsers scope 
 [-] Error occurred in Describe block 0ms 
 IOException: The directory is not empty. : 'C:\Users\VssAdministrator\Documents\PowerShell\Help\' 
 IOException: Cannot remove item C:\Users\VssAdministrator\Documents\PowerShell\Help\: The directory is not empty. : 'C:\Users\VssAdministrator\Documents\PowerShell\Help\' 
 at <ScriptBlock>, D:\a\1\s\test\powershell\engine\Help\HelpSystem.Tests.ps1: line 267 
 at Invoke-Blocks, D:\a\1\s\src\powershell-win-core\bin\Release\net6.0\win7-x64\publish\Modules\Pester\4.10.1\Functions\SetupTeardown.ps1: line 135 
 at Invoke-TestGroupSetupBlocks, D:\a\1\s\src\powershell-win-core\bin\Release\net6.0\win7-x64\publish\Modules\Pester\4.10.1\Functions\SetupTeardown.ps1: line 121 
 at DescribeImpl, D:\a\1\s\src\powershell-win-core\bin\Release\net6.0\win7-x64\publish\Modules\Pester\4.10.1\Functions\Describe.ps1: line 209 

PR Checklist

• PR has a meaningful title
  • Use the present tense and imperative mood when describing your changes
• Summarized changes
• Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
• This PR is ready to merge and is not Work in Progress.
  • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
• Breaking changes
  • None
  • OR
  • Experimental feature(s) needed
    • Experimental feature name(s):
• User-facing changes
  • Not Applicable
  • OR
  • Documentation needed
    • Issue filed:
• Testing - New and feature
  • N/A or can only be tested interactively
  • OR
  • Make sure you've added a new test if existing tests do not effectively test the code changed
• Tooling
  • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
  • OR
  • I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:
    • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
      (which runs in a different PS Host).
      • Issue filed:
    • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
      • Issue filed:
    • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
      • Issue filed:
    • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
      • Issue filed:

[TravisEz13]

/azp list

[azure-pipelines]

CI/CD Pipelines for this repository:

• PowerShell-CI-macos
• PowerShell-CI-linux
• PowerShell-CI-windows
• PowerShell-CI-static-analysis
• PowerShell-CI-Windows-daily
• PowerShell-CI-install-ps
• PowerShell-CI-SSH
• SSH-Tests
• PowerShell-Windows-Packaging-CI

[TravisEz13]

/azp run PowerShell-CI-Windows-daily

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[rjmholt]

@iSazonov #14902 caused an issue with Remove-Item, forcing us to revert it:

  Describing About help files can be found in AllUsers scope
    [-] Error occurred in Describe block 0ms
      IOException: The directory is not empty. : 'C:\Users\VssAdministrator\Documents\PowerShell\Help\'
      IOException: Cannot remove item C:\Users\VssAdministrator\Documents\PowerShell\Help\: The directory is not empty. : 'C:\Users\VssAdministrator\Documents\PowerShell\Help\'
      at <ScriptBlock>, D:\a\1\s\test\powershell\engine\Help\HelpSystem.Tests.ps1: line 267
      at Invoke-Blocks, D:\a\1\s\src\powershell-win-core\bin\Release\net6.0\win7-x64\publish\Modules\Pester\4.10.1\Functions\SetupTeardown.ps1: line 135
      at Invoke-TestGroupSetupBlocks, D:\a\1\s\src\powershell-win-core\bin\Release\net6.0\win7-x64\publish\Modules\Pester\4.10.1\Functions\SetupTeardown.ps1: line 121
      at DescribeImpl, D:\a\1\s\src\powershell-win-core\bin\Release\net6.0\win7-x64\publish\Modules\Pester\4.10.1\Functions\Describe.ps1: line 209

[JamesWTruher]

extra white space?

[iSazonov]

Yes, will remove in follow PR.

[iSazonov]

I wonder how was CIs passed in the PR. Should we fix anything in CIs?

[TravisEz13]

@iSazonov No the daily CI run serially. You should open a new PR and fix the issue in the remove-item code.