Skip to content

Remove 1s minimum delay in Invoke-WebRequest for small files, and prevent file-download-error suppression. #17896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 10 commits into from
Aug 23, 2022
Merged

Remove 1s minimum delay in Invoke-WebRequest for small files, and prevent file-download-error suppression. #17896

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0fec7ea
fix perf issue of 1s min constant delay with Invoke-WebRequest
Aug 14, 2022
9e4b55d
pr feedback: refactor wait loop
Aug 15, 2022
d172ef0
Update src/Microsoft.PowerShell.Commands.Utility/commands/utility/Web…
AAATechGuy Aug 16, 2022
f127ba8
Revert "Update src/Microsoft.PowerShell.Commands.Utility/commands/uti…
Aug 17, 2022
7d65984
Update src/Microsoft.PowerShell.Commands.Utility/commands/utility/Web…
AAATechGuy Aug 18, 2022
b0cc3d4
fix issue in suggestion
Aug 18, 2022
2add09d
fix build issue
Aug 18, 2022
837bda2
add comment for suppression
Aug 18, 2022
96e1650
code refactor
Aug 18, 2022
be5e2d6
remove AggregateEx handler.
Aug 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/Microsoft.PowerShell.Commands.Utility/commands/utility/WebCmdlet/StreamHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,16 +289,14 @@ internal static void WriteToStream(Stream input, Stream output, PSCmdlet cmdlet,
ActivityId,
WebCmdletStrings.WriteRequestProgressActivity,
WebCmdletStrings.WriteRequestProgressStatus);

try
{
do
while (!copyTask.Wait(1000, cancellationToken))
{
record.StatusDescription = StringUtil.Format(WebCmdletStrings.WriteRequestProgressStatus, output.Position);
cmdlet.WriteProgress(record);

Task.Delay(1000).Wait(cancellationToken);
}
while (!copyTask.IsCompleted && !cancellationToken.IsCancellationRequested);

if (copyTask.IsCompleted)
{
Expand Down