[release/v7.5] Correct the package name for .deb and .rpm packages#26964
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Travis Plunk <travis.plunk@microsoft.com>
adityapatwardhan
added
the
CL-BuildPackaging
There was a problem hiding this comment.
Pull request overview
Backports a packaging fix to release/v7.5 so that .deb and .rpm preview builds use the correct -preview package naming/channel suffix expected on packages.microsoft.com, and adjusts macOS CI gating for packaging runs.
Changes:
- Update Unix packaging name selection so preview
.deb/.rpmpackages usepowershell-preview(while keeping macOS.pkgnaming behavior unchanged). - Update macOS CI “macOS packaging and testing” job to run based on
packagingChangedpath-filter output, and expose that output from the change-detection job.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
tools/packaging/packaging.psm1 |
Uses Test-IsPreview to emit powershell-preview naming for preview .deb/.rpm packages (excluding osxpkg). |
.github/workflows/macos-ci.yml |
Changes macOS packaging job gating to rely on packagingChanged from path filters. |
| needs: | ||
| - changes | ||
| if: ${{ needs.changes.outputs.source == 'true' || needs.changes.outputs.buildModuleChanged == 'true' }} | ||
| if: ${{ needs.changes.outputs.packagingChanged == 'true' }} |
There was a problem hiding this comment.
The new condition gates the macOS packaging job exclusively on packagingChanged, but the path-filters composite action does not set packagingChanged for non-PR events (push). On push runs needs.changes.outputs.packagingChanged will be empty, so this job will be skipped entirely (previously it ran because source/buildModuleChanged are forced true on non-PR). Consider either (a) updating the path-filters action to set packagingChanged (and globalConfigChanged) to true on non-PR events, or (b) widening this if: to include push events (e.g., run when github.event_name != 'pull_request' or when needs.changes.outputs.source == 'true'). Also note packagingChanged currently doesn't include macOS packaging paths (e.g., .github/workflows/macos-ci.yml, test/packaging/macos/), so macOS packaging-related changes may not trigger this job.
| if: ${{ needs.changes.outputs.packagingChanged == 'true' }} | |
| if: ${{ github.event_name != 'pull_request' || needs.changes.outputs.packagingChanged == 'true' }} |
Backport of #26877 to release/v7.5
Triggered by @adityapatwardhan on behalf of @daxian-dbw
Original CL Label: CL-BuildPackaging
/cc @PowerShell/powershell-maintainers
Impact
REQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected.
Tooling Impact
Corrects the package name for .deb and .rpm packages to use the proper '-preview' channel suffix for preview builds, matching existing names on packages.microsoft.com.
Customer Impact
Regression
REQUIRED: Check exactly one box.
This is not a regression.
Testing
Clean cherry-pick with no conflicts. Existing packaging CI tests cover the .deb/.rpm name correction. Verified by the original PR's merge to master and successful backports to v7.6 (#26884) and v7.4 (#26954).
Risk
REQUIRED: Check exactly one box.
This is a straightforward cherry-pick of a packaging name fix that has already been successfully backported to both v7.6 and v7.4 without issues. The change corrects .deb and .rpm package naming and applied cleanly with no conflicts.