Skip to content

[release/v7.6] Fix ConvertFrom-ClearlyDefinedCoordinates to handle API object coordinates#26986

Merged
jshigetomi merged 1 commit intoPowerShell:release/v7.6from
daxian-dbw:backport/release/v7.6/26893-312291762
Mar 10, 2026
Merged

[release/v7.6] Fix ConvertFrom-ClearlyDefinedCoordinates to handle API object coordinates#26986
jshigetomi merged 1 commit intoPowerShell:release/v7.6from
daxian-dbw:backport/release/v7.6/26893-312291762

Conversation

@daxian-dbw
Copy link
Member

Backport of #26893 to release/v7.6

Triggered by @daxian-dbw on behalf of @app/copilot-swe-agent

Original CL Label: CL-BuildPackaging

/cc @PowerShell/powershell-maintainers

Impact

REQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected.

Tooling Impact

  • Required tooling change
  • Optional tooling change (include reasoning)

Fixes ClearlyDefined license generation tooling. The ConvertFrom-ClearlyDefinedCoordinates function only accepted string input, but Get-ClearlyDefinedData returns PSCustomObject from the API. This caused Start-ClearlyDefinedHarvest to fail. Backporting only the ClearlyDefined.psm1 fix (reverted all dependency updates).

Customer Impact

  • Customer reported
  • Found internally

Regression

REQUIRED: Check exactly one box.

  • Yes
  • No

This is not a regression.

Testing

Original PR tested with ClearlyDefined API responses. Backport verified by reviewing diff shows only ClearlyDefined.psm1 changes.

Risk

REQUIRED: Check exactly one box.

  • High
  • Medium
  • Low

Low risk - isolated change to a single tooling script used for license generation. Only affects ClearlyDefined coordinate parsing logic. Does not impact runtime or user-facing features. Change adds conditional logic to handle both input types without breaking existing string input handling.

Merge Conflicts

6 files had conflicts (dependency version updates). Resolved by reverting all changes except ClearlyDefined.psm1 to keep only the tooling fix without pulling in dependency updates.

…nates (PowerShell#26893)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: TravisEz13 <10873629+TravisEz13@users.noreply.github.com>
Co-authored-by: Travis Plunk <travis.plunk@microsoft.com>
Co-authored-by: PowerShell Team Bot <69177312+pwshBot@users.noreply.github.com>
Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
Copilot AI review requested due to automatic review settings March 10, 2026 22:37
@daxian-dbw daxian-dbw requested a review from jshigetomi as a code owner March 10, 2026 22:37
@daxian-dbw daxian-dbw added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Mar 10, 2026
@daxian-dbw daxian-dbw requested a review from a team as a code owner March 10, 2026 22:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Backport to release/v7.6 that fixes ClearlyDefined license-generation tooling by making ConvertFrom-ClearlyDefinedCoordinates handle the coordinates value returned as an API object (in addition to the existing string form), preventing downstream harvest failures.

Changes:

  • Broaden ConvertFrom-ClearlyDefinedCoordinates input from [string] to [object].
  • Add branching logic to parse either a coordinate string (type/provider/namespace/name/revision) or a PSCustomObject with type/provider/namespace/name/revision properties.

@jshigetomi jshigetomi merged commit f9a6fa4 into PowerShell:release/v7.6 Mar 10, 2026
39 checks passed
@daxian-dbw daxian-dbw deleted the backport/release/v7.6/26893-312291762 branch March 10, 2026 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants