Fix API markets timeout issue#548
Merged
Merged
Conversation
|
@MKNas01 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Merged via direct push to main (admin) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #396
This PR implements a per-request graceful timeout on the
/api/marketsendpoints to fulfill the backend requirements for the GrantFox FWC26 campaign (Stellar Wave).Changes Made
requestTimeoutinsrc/middleware/timeout.tsutilizingAbortControllerto gracefully terminate requests exceeding the limit (set to 10 seconds).marketsRouterimmediately following the rate limiters.logger.warn) capturing thecorrelationIdand returning a standardized408 Request Timeouterror envelope when triggered.408response on delayed queries. Minimum 90% coverage achieved on changed lines.docs/markets-api.mdto reflect the new408 timeouterror visibility.Acceptance Criteria Checklist