Deploy scripts - #49
Conversation
| DOCS_BASE_URL: process.env.DOCS_BASE_URL ?? "https://devdocs.prestashop-project.org/", | ||
| DOCS_VERSION: process.env.DOCS_VERSION ?? "9", | ||
| ALGOLIA_APP_ID: process.env.ALGOLIA_APP_ID ?? "79DO4UR9Y5", | ||
| ALGOLIA_API_KEY: process.env.ALGOLIA_API_KEY ?? "352524fc37137a45610faa44bcc1a47c", |
There was a problem hiding this comment.
This git repo is public, this PR is also public, this API key should considered as leaked and should be revoked as quickly as possible.
There was a problem hiding this comment.
Don't worry, both keys are public.
There was a problem hiding this comment.
To be more precise: It's a search-only key that's always public.
There was a problem hiding this comment.
Can you add a comment to the code explaining this context. This can also help when secret-detection is added to the security measures, having an explicit exception here.
There was a problem hiding this comment.
good point, there's a docblock above now
|
Can you split into multiple commits since there are multiple changes in a single commit which indicates little information about the changes made ? |
|
Why is GCP Cloud Run the target deployment technology ? |
67fde11 to
9865436
Compare
The MCP core (src/index.ts) is unchanged; src/server.ts is a ~70-line node:http adapter around it and becomes the only entry point. Drops the wrangler and @cloudflare/workers-types dependencies (lockfile shrinks by ~1600 lines), switches tsconfig to @types/node, and removes wrangler.jsonc. Note: bin/mcp-local.sh still points at wrangler until the follow-up commit in this sequence. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
bin/mcp-local.sh builds and starts dist/server.mjs instead of wrangler dev; shutdown still guarantees both ports are freed. Root README wording updated to match. npm run mcp:local / mcp:test unchanged for users. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
9865436 to
1036817
Compare
| ALGOLIA_INDEX: process.env.ALGOLIA_INDEX ?? "prestashop", | ||
| }; | ||
|
|
||
| // Cloud Run injects PORT; default to its convention locally too. |
There was a problem hiding this comment.
A left over Cloud Run mention which can be removed
| # Container image for the devdocs MCP server. Host-agnostic: the same image runs on | ||
| # Kubernetes, Cloud Run, or anything else that can start a container. | ||
|
|
||
| FROM node:22-slim AS build |
There was a problem hiding this comment.
Node 24 is the most recent current LTS version. Is there a reason why Node 22 is being used ?
| * translates Node's http primitives to Request/Response and back. It is the sole | ||
| * entry point for local development and for the container image alike. | ||
| * | ||
| * The `cf:` cache hints index.ts passes to fetch() are a leftover of the original |
There was a problem hiding this comment.
Is this comment still necessary ? I don't see any cf or cache in the server.ts file ...
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2 participants
No description provided.