C morph ball extract inline helpers + label data reinterpretation

[ShulkMaster]

• Replace raw Morph Ball glow byte arrays with typed RGB color palettes.
• Add reusable helpers for glow and ambient color conversion.
• Refactor Morph Ball glow, transition flash, and lighting code to use the new helpers.
• remove raw pointers arithmetic while preserving matching compiler output.

[decomp-dev]

Report for GM8E01_48 (7c3d8a7 - b941c2b)

No changes

Report for GM8E01_00 (7c3d8a7 - b941c2b)

📈 Matched code: 37.05% (+0.00%, +144 bytes)

✅ 1 new match

Unit	Item	Bytes	Before	After
main/MetroidPrime/Player/CMorphBall	CMorphBall::RenderMorphBallTransitionFlash(const CStateManager&) const	+2	98.89%	100.00%

📈 2 improvements in unmatched items

Unit	Item	Bytes	Before	After
main/MetroidPrime/Player/CMorphBall	CMorphBall::Render(const CStateManager&, const CActorLights*) const	+3	99.42%	99.50%
main/MetroidPrime/Player/CMorphBall	CMorphBall::PreRender(CStateManager&, const CFrustumPlanes&)	+1	99.46%	99.53%

---

Report for GM8E01_01 (7c3d8a7 - b941c2b)

📈 Matched code: 35.88% (+0.00%, +144 bytes)

✅ 1 new match

Unit	Item	Bytes	Before	After
main/MetroidPrime/Player/CMorphBall	CMorphBall::RenderMorphBallTransitionFlash(const CStateManager&) const	+2	98.89%	100.00%

📈 1 improvement in an unmatched item

Unit	Item	Bytes	Before	After
main/MetroidPrime/Player/CMorphBall	CMorphBall::PreRender(CStateManager&, const CFrustumPlanes&)	+1	99.46%	99.53%

[Antidote]

LGTM, I'll see if I can find the names for those globals in either the map or Remastered so we can get those updated as well.

[ShulkMaster]

LGTM, I'll see if I can find the names for those globals in either the map or Remastered so we can get those updated as well.

sure, thanks. I have no idea what to name them.

[Antidote]

skBallBoostedHullGlowColors 
skBallBoostedHullGlowIntensities 
skBallBoostedSwooshColors 
skBallBoostedSwooshIntensity 
skBallDamagedHullFlashIntensities 
skBalllceModels 
skBallLightColors 
skBallLightningSwooshColors 
skBallNormalSwooshColors 
skBallNormalSwooshIntensity 
skGlassModels 
skInnerGlowBoostedIntensityPrimary 
skInnerGlowBoostedLightInnerAngle 
skInnerGlowBoostedLightInnerRadius 
skInnerGlowBoostedLightIntensity 
skInnerGlowBoostedLightOuterAngle 
sklnnerGlowBoostedLightRadius 
skInnerGlowNormalIntensityPrimary 
skInnerGlowNormalLightInnerAngle 
skInnerGlowNormalLightInnerRadius 
skInnerGlowNormalLightIntensity 
skInnerGlowNormalLightOuterAngle 
sklnnerGlowNormalLightRadius 
skLowPolySpiderBalls 
skNormalBallColorindices 
skNormalBalls 
skNormalLowPolyBalls 
skSpiderBallColorIndices 
skSpiderBalls 
skSwooshHorizontalOffset 
skSwooshVerticalOffset 

this is what I was able to recover from Remastered, unfortunately the audio lookup tables don't have names, but we can use context clues to come up with our own.

Oh, they're all located in the CMorphBall class, so they can be moved there instead of that unnamed namespace, that also includes the related helpers, they can be static members functions for each table rather than taking the table as an argument, that's how Retro usually handles utilities like this.

[ShulkMaster]

I have move the statics variables from a NS into the class as static members, following the sk retro naming convention + name based on apparent usage

[Antidote]

Can you rebase against main?