Skip to content

prime lab setup doesn't gitignore .grok/skills when Grok is a selected agent #790

Description

@martian56

What happens

Running prime lab setup and picking grok as one of the coding agents scaffolds a .grok/skills/ directory in the workspace, but that path never gets added to .gitignore, and prime lab hygiene / prime lab doctor don't treat it as generated either. Every other supported agent has its skills directory ignored (.claude/skills/, .cursor/skills/, .factory/skills/, .pi/skills/, ...), so grok is the odd one out and its generated files can be committed by accident.

Steps to reproduce

$ prime lab setup
Supported coding agents: amp, claude, codex, cursor, droid, grok, hermes, letta, opencode, pi
Primary coding agent [codex]: claude
Using multiple coding agents? [y/N]: y
Additional agents (comma-separated): codex, grok
...
$ git status
# .grok/skills/ shows up as untracked

Expected

.grok/skills/ is ignored the same way the other agents' skill directories are, and prime lab hygiene / prime lab doctor flag it as generated rather than committable.

Where it comes from

LAB_GITIGNORE_PATTERNS and LAB_TRACKED_PREFIXES in packages/prime/src/prime_cli/lab_hygiene.py list the per-agent skills directories by hand. Grok's project skill root (.grok/skills, from _AGENT_PROJECT_SKILL_ROOTS in lab_agents.py) is missing from both. The existing gitignore tests only assert /.agents/skills/, so nothing caught the gap.

Happy to send a PR that derives both lists from a single source of truth and adds a test that covers every agent in the registry so this can't drift again.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions