Add top-level enable_thinking and reasoning_effort to RL config#526
Merged
Add top-level enable_thinking and reasoning_effort to RL config#526
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 43cbb1a. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adds the two hosted RL reasoning controls added to the backend in platform#1390 as top-level fields on
RLConfig, so users don't have to guess the nestedsampling.extra_body.chat_template_kwargspath.enable_thinking: bool— Qwen3.5 / Nemotronreasoning_effort: "low" | "medium" | "high"— GPT-OSScreate_run; server resolves model-family + trainer-image-version pathNote
Low Risk
Low risk: adds optional config fields and forwards them to the existing run-creation API, with a small new validation rule that only errors when both options are set.
Overview
Adds two optional, top-level hosted RL reasoning controls to
RLConfig—enable_thinkingandreasoning_effort—including client-side mutual-exclusion validation and updatedrl inittemplate/docs.Updates
RLClient.create_runand theprime rl runflow to display these settings and forward them 1:1 in the/rft/runspayload, and adds tests covering config loading and rejection when both controls are provided.Reviewed by Cursor Bugbot for commit 2dec5c6. Bugbot is set up for automated code reviews on this repo. Configure here.