Move enable_thinking and reasoning_effort under [sampling]#558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #526. These belong under
[sampling]alongside other sampling controls, not at top level.RLConfig.enable_thinking/reasoning_effort→SamplingConfigNote
Medium Risk
Medium risk because it changes the RL TOML config schema: existing configs using top-level
enable_thinking/reasoning_effortwill now fail validation and must be moved under[sampling]. Runtime behavior is otherwise unchanged aside from where values are read and displayed.Overview
Moves hosted RL reasoning controls (
enable_thinking,reasoning_effort) from top-levelRLConfigintoSamplingConfigunder[sampling], including relocating the mutual-exclusion validator.Updates the generated config template, CLI run summary output (now shown in the Sampling section), and the
create_runAPI payload mapping to read these values fromcfg.sampling. Tests are updated to require[sampling]usage and add coverage that top-levelreasoning_effortis rejected.Reviewed by Cursor Bugbot for commit 4cc1cda. Bugbot is set up for automated code reviews on this repo. Configure here.