Skip to content

fix(v1): use typed ACP turn in Prime Agent harness - #2443

Merged
hallerite merged 1 commit into
mainfrom
codex/fix-prime-agent-acp-turn
Aug 26, 2026
Merged

fix(v1): use typed ACP turn in Prime Agent harness#2443
hallerite merged 1 commit into
mainfrom
codex/fix-prime-agent-acp-turn

Conversation

@hallerite

@hallerite hallerite commented Aug 26, 2026

Copy link
Copy Markdown
Member

Summary

Root cause

PR #2440 retained the earlier ACPTurnResult name while PR #2438 landed the public type as ACPTurn. Importing the built-in harness package therefore raised ImportError.

Validation

  • exact deterministic V1 CI command: 71 passed
  • full test suite exits successfully; credential-gated live tests skipped locally
  • uv run ty check verifiers
  • uv run ruff check --fix .
  • changed-file pre-commit hooks

The branch is based on newest main after RLM hotfix #2442.


Note

Low Risk
Rename-only type alignment with no logic changes; fixes import/discovery breakage.

Overview
Aligns the Prime Agent harness with the v1 ACP base after the public turn type was renamed from ACPTurnResult to ACPTurn.

The import and acp_turn_result parameter type are updated only; lifecycle handling is unchanged. This removes the ImportError that broke built-in harness package discovery when stacked PRs landed the new name in verifiers.v1.acp but Prime Agent still imported the old symbol.

Reviewed by Cursor Bugbot for commit 6ee1df9. Bugbot is set up for automated code reviews on this repo. Configure here.

@hallerite
hallerite merged commit baa6a86 into main Aug 26, 2026
13 checks passed
@hallerite
hallerite deleted the codex/fix-prime-agent-acp-turn branch August 26, 2026 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants