fix(v1): reconcile concurrent graph commits - #2477
Merged
Merged
Conversation
Contributor
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This core v1 graph fix changes production node reuse and branch topology for concurrent evaluation and training requests, including token attribution and leaf identities. The reconciliation logic is nontrivial shared infrastructure rather than a small isolated correction. You can add or adjust custom eligibility rules. Learn more. |
mikasenghaas
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prepare_turnandcommitoperationsThis is a generic
maingraph fix. The ACP semantic-edge work remains separate in #2449.Reproduction
With two concurrent nano-RLM children, both first requests prepared before either committed. The second commit created a duplicate system root and overwrote the lookup entry; the first child later re-rooted through the second root, leaving an orphan leaf.
Before the fix:
2 + 1(parent, message_hash)identityBefore-fix live trace
Post-fix stress run
DeepSeek continued spawning children until the 30-minute rollout timeout, producing a stronger concurrency test:
(parent, message_hash)identitiesThe timeout made final ACP metrics unavailable, but the interception trace was sealed and retained the complete physical graph.
Post-fix live trace
Validation
uv run pytest -q tests/v1/test_graph.py: 10 passedtests/suite passed before the final boundary-only regression; credential-gated cases skipped