fix: require aiohttp 3.14 or newer - #2479
Merged
Merged
Conversation
mikasenghaas
marked this pull request as ready for review
August 31, 2026 18:14
hallerite
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aiohttp>=3.14.0, the first release that providesweb.RequestKey.Verification
Before this change, aiohttp 3.13.5 does not provide
web.RequestKey. Importingverifiers.v1fails ininterception/server.py.After this change, package resolution requires aiohttp 3.14.0 or newer. The Verifiers test suite passes with its locked aiohttp 3.14.3 release.
uv lock --checkuv run ruff check --fix .uv run pytest tests/(864 passed, 76 skipped)uv run pre-commit run --files pyproject.tomluv run pre-commit run --all-filesreports the existing MD033 inline-HTML errors inverifiers/legacy/envs/experimental/composable/tasksets/swe/README.md.Note
Require
aiohttp>=3.14.0in project dependenciesUpdates the dependency constraint in pyproject.toml from
>=3.9.0to>=3.14.0. This raises the minimum supported version of aiohttp for all installations.Risk: environments pinned to aiohttp versions between 3.9.0 and 3.13.x will fail to install or upgrade until aiohttp is updated.
Macroscope summarized 7e41311.
Note
Low Risk
Single dependency floor change with no runtime logic edits; only affects environments still pinned below aiohttp 3.14.
Overview
Raises the minimum aiohttp version in
pyproject.tomlfrom>=3.9.0to>=3.14.0, matching the first release that exposesweb.RequestKey.That API is used in v1 interception (e.g.
verifiers/v1/interception/server.py); with older aiohttp, importingverifiers.v1could fail at import time. Installers and lockfiles will no longer resolve aiohttp 3.9–3.13.x for this package.Reviewed by Cursor Bugbot for commit 7e41311. Bugbot is set up for automated code reviews on this repo. Configure here.