Skip to content

Simplify Modal egress domain-list construction #2587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xeophon merged 1 commit into from
Sep 11, 2026
+3 −13
Merged

Simplify Modal egress domain-list construction #2587

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 3 additions & 13 deletions verifiers/v1/runtimes/modal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,19 +260,9 @@ async def prepare_execution(self, routes: list[str] | None) -> None:
if routes is None:
domains, cidrs = ["*"], ["0.0.0.0/0"]
else:
domains = list(
dict.fromkeys(
domain
for domain in [
*(
_egress_domain(route, framework=True)
for route in routes
),
*(_egress_domain(rule) for rule in self.config.allow),
]
if domain is not None
)
)
domains = [_egress_domain(route, framework=True) for route in routes]
domains.extend(_egress_domain(rule) for rule in self.config.allow)
domains = list(dict.fromkeys(d for d in domains if d is not None))
cidrs = []
# Always send both lists: leaving the setup CIDR grant would bypass domains.
# The awaited RPC applies the policy and closes newly disallowed connections.
Expand Down