You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks again for contributing.
I'm a bit worried though when it comes to making changes to the c-like component, since it's used by many other components.
So I did a thorough check of each language using it, to see whether or not they support binary literals. The first thing that surprised me is that Standard C does not seem to support binary literals. AFAICT, although they are supported in GCC, they were only added in C++14. Therefore, I think they should be added to the cpp component instead of the c component.
Here follow the results of the current support state for binary literals in C-like languages in Prism.
So, as you can (hopefully) see from this table, there is a number of languages that do not have support for binary literals and do not override the definition of the numbers pattern inherited from the c-like component. This means adding support for binary literals in the c-like component would add unwanted support for them in those languages, and I don't think we want this to happen.
I'm closing this PR. If you want, feel free to create a new one to add support for binary literals in the cpp component instead (by redefining the numbers pattern entirely).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0b0101001