Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint: Allow Map and Set in ES5 code #3328

Merged
merged 1 commit into from Feb 10, 2022

Conversation

RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Feb 10, 2022

See this reply for context.

Briefly, IE11 partially supports Set and Map, so we should be allowed to use them throughout our code base. However, ESLint is configured to only allow ES5 code, so it rejects Set and Map as undefined variables. This PR adds an exception to our ESLint config to declare Set and Map as defined.

@RunDevelopment
Copy link
Member Author

@RunDevelopment RunDevelopment commented Feb 10, 2022

Since this is a very small and required by #3326, I will merge this after all tests pass.

@github-actions
Copy link

@github-actions github-actions bot commented Feb 10, 2022

No JS Changes

Generated by 🚫 dangerJS against d9984ee

@RunDevelopment RunDevelopment merged commit f545843 into PrismJS:master Feb 10, 2022
12 checks passed
@RunDevelopment RunDevelopment deleted the eslint-map-set branch Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant