Skip to content

Fix Magik to allow ? and ! in variable names#4078

Merged
DmitrySharabin merged 2 commits into
PrismJS:v2from
sebastiaanspeck:fix/magik-variables-with-question-mark
May 19, 2026
Merged

Fix Magik to allow ? and ! in variable names#4078
DmitrySharabin merged 2 commits into
PrismJS:v2from
sebastiaanspeck:fix/magik-variables-with-question-mark

Conversation

@sebastiaanspeck
Copy link
Copy Markdown
Contributor

No description provided.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 2, 2026

Deploy Preview for dev-prismjs-com ready!

Name Link
🔨 Latest commit 43ce401
🔍 Latest deploy log https://app.netlify.com/projects/dev-prismjs-com/deploys/6a0c6d9f8c2a0d000858f330
😎 Deploy Preview https://deploy-preview-4078--dev-prismjs-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 2, 2026

No JS Changes

Generated by 🚫 dangerJS against 43ce401

@sebastiaanspeck
Copy link
Copy Markdown
Contributor Author

@DmitrySharabin can you please have a look? npm run test:languages does work, but test:identifiers fails somehow.

Copy link
Copy Markdown
Member

@DmitrySharabin DmitrySharabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sebastiaanspeck,

Thanks for being patient. I left a comment on why you face the issue and how to fix it. I hope it helps!

Comment thread src/languages/magik.js Outdated
Co-authored-by: Dmitry Sharabin <dmitrysharabin@gmail.com>
Copy link
Copy Markdown
Member

@DmitrySharabin DmitrySharabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DmitrySharabin DmitrySharabin merged commit e34622a into PrismJS:v2 May 19, 2026
13 of 14 checks passed
@DmitrySharabin
Copy link
Copy Markdown
Member

Thank you! Merged.

@sebastiaanspeck sebastiaanspeck deleted the fix/magik-variables-with-question-mark branch May 19, 2026 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants