sec: Fix a SQL injection in advanced search - #236
Merged
Conversation
The advanced search was subject to an attack by SQL injection. A malicious user with admin rights could forge a request and alter the sort parameters in order to execute a SQL request, such as a DELETE statement. The attack is difficult to exploit by an external attacker as a POST request must be performed and the session cookies are not sent if the HTTP request is performed from outside AgentJ thanks to the `SameSite` policy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The advanced search was subject to an attack by SQL injection. A malicious user with admin rights could forge a request and alter the sort parameters in order to execute a SQL request, such as a DELETE statement.
The attack is difficult to exploit by an external attacker as a POST request must be performed and the session cookies are not sent if the HTTP request is performed from outside AgentJ thanks to the
SameSitepolicy.Related issue(s)
N/A
How to test manually
Reviewer checklist