Skip to content

FOUR-15339: Improve saved search sorting performance#6823

Merged
ryancooley merged 3 commits into
nextfrom
bugfix/FOUR-15339
May 4, 2024
Merged

FOUR-15339: Improve saved search sorting performance#6823
ryancooley merged 3 commits into
nextfrom
bugfix/FOUR-15339

Conversation

@runyan-co

@runyan-co runyan-co commented May 3, 2024

Copy link
Copy Markdown
Contributor

Issue

Sorting for saved searches with a large results (generally 1000+ tasks) are slow (3+ secs) when sorted.

Reproduction Steps

  1. Log in
  2. Go to Tasks page
  3. Have 1000 or more tasks
  4. Filters works to status column
  5. Create a saved search
  6. Use Filters to status column

Solution

There were duplicate queries for selecting and counting the results of the saved search query, deduplicating them improve performance.

How to Test

Resort the same saved search and notice the improved speed.

Related Tickets & Packages

CICD

ci:next
ci:deploy
ci:package-savedsearch:bugfix/FOUR-15339

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

.

@runyan-co runyan-co self-assigned this May 3, 2024
@tokensPM

tokensPM commented May 3, 2024

Copy link
Copy Markdown

QA server K8S was successfully deployed https://ci-39e4651b94.engk8s.processmaker.net

@runyan-co
runyan-co requested a review from marcoAntonioNina May 3, 2024 22:05
@tokensPM

tokensPM commented May 3, 2024

Copy link
Copy Markdown

QA server K8S was successfully deployed https://ci-39e4651b94.engk8s.processmaker.net

Comment thread ProcessMaker/Http/Controllers/Api/TaskController.php Outdated
@tokensPM

tokensPM commented May 4, 2024

Copy link
Copy Markdown

QA server K8S was successfully deployed https://ci-39e4651b94.engk8s.processmaker.net

@processmaker-sonarqube

Copy link
Copy Markdown

@ryancooley
ryancooley merged commit aa78ae2 into next May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants