feat: Add stylized subtitles toggle - #192
Merged
ProdigyV21 merged 2 commits intoMay 15, 2026
Merged
Conversation
Owner
|
Nice feature, especially for anime ASS/SSA subtitles. The merge build passes, but I think two things should be fixed before merging.
Please apply the user
Please add Checks passed:
|
Collaborator
Author
|
Addressed both review items in Himanth-reddy:feat/stylized-subtitles.
Checks passed locally:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses stylized anime subtitles request from #180
Description
Adds a new setting to enable stylized subtitles for ASS/SSA subtitle formats.
Changes
subtitle_stylizedstring resources.subtitleStylizedpreference toPlayerUiStateandSettingsUiState.PlayerScreento conditionally applysetApplyEmbeddedStyles(true)andsetApplyEmbeddedFontSizes(true)onSubtitleViewwhen enabled. When disabled, the fallback custom sizes and colors viaCaptionStyleCompatare used.SettingsScreento include the Stylized Subtitles toggle in both the TV layout and Mobile layout, properly managing D-pad navigation indexes for the TV layout.