fix(search): fix TV filter focus reversion and align mobile catalog layout - #649
Merged
ProdigyV21 merged 4 commits intoSep 5, 2026
Conversation
…ayout - Fix TV D-pad filter selection: isolate selection to D-pad modifier, remove competing focusable/click modifiers on TV GlowChips, and preserve selected filter index when navigating down from the search bar. - Fix focus jumping to search bar on TV filter selection: anchor native focus with filtersFocusRequester and guard search bar onFocused so background category reload passes cannot hijack the active zone away from FILTERS. - Unify mobile search screen layout with HomeScreen: remove 289dp rigid row height and replace with natural Column spacing (spacedBy 20dp), align card dimensions (120dp portrait / 200dp landscape) and horizontal spacing (14dp), disable TV row dimming and focus outlines on touch devices, and add statusBarsPadding with 16dp horizontal insets.
github-actions
Bot
added
the
area: android
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses two search screen issues:
TV Search Filter Focus & Reversion Bugs:
GlowChiphad competing Compose.clickable,.focusable(), and native focus hooks where only chip 0 had aFocusRequester. On D-pad selection, native click/KeyUp on chip 0 immediately reverted selection to "All".SearchInputBar, whoseonFocusedcallback resetfocusZone = FocusZone.SEARCH_INPUT.filtersFocusRequesteronDiscoverFilterStrip'sLazyRow, guardedSearchInputBar.onFocusedso background Compose focus events cannot hijack the active zone away fromFILTERS, and preserved the active filter selection when navigating down from the search bar.Mobile Search Screen Layout Alignment with Home:
289.dprow container height on mobile (isTouchDevice), allowing catalog rows to wrap content naturally in aColumnspaced by20.dpon the parentLazyColumn(matchingMobileHomeRowsLayer).120.dpportrait /200.dplandscape) and horizontal spacing (14.dpinLazyRow), matchingHomeScreen.kt.rowAlpha = 1f) and focus outlines on touch devices.statusBarsPadding()and aligned horizontal insets (16dp padding) to respect device notches and display edges.Testing
./gradlew compileSideloadDebugKotlin.arm64-v8a,armeabi-v7a,x86,x86_64) via./gradlew assembleSideloadDebug -PincludeX86Abis=true.