fix(navigation): load mobile bottom nav bar on initial cloud connect - #653
Merged
Merged
Conversation
github-actions
Bot
added
the
area: android
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug in the mobile version of the application where clicking "Connect to ARVIO Cloud" when launching the application for the first time fails to load the bottom navigation bar.
Root Cause
When the app is opened for the first time, no active profile exists yet (
activeProfile == null). Previously,showBottomBarinMainActivity.ktexplicitly requiredactiveProfile != nullalong with checking for non-profile/login/player screens. Consequently, when navigating from initial profile selection to Settings (settings?autoCloudAuth=true),showBottomBarevaluated tofalse, hiding the bottom navigation bar.Changes
AppBottomBar.kt: IntroducedshouldShowBottomBarhelper function to ensure the bottom bar is shown on all non-fullscreen mobile screens other than profile selection and login.MainActivity.kt: UpdatedshowBottomBarto useshouldShowBottomBar.AppNavigation.kt: Safely pop tostartDestinationIdwhen switching profiles from Settings.AppBottomBarResponsiveLayoutTest.kt: Added unit test coverage for initial launch cloud connect, profile selection, login, player fullscreen, and non-mobile devices.