Skip to content

Order the row actions by what they do to the row - #1366

Merged
JeroenDeDauw merged 2 commits into
masterfrom
feature/row-action-order
Sep 7, 2026
Merged

Order the row actions by what they do to the row#1366
JeroenDeDauw merged 2 commits into
masterfrom
feature/row-action-order

Conversation

@JeroenDeDauw

Copy link
Copy Markdown
Member

Follows-up to #1356

The Data tab's row actions ran Promote, Edit, Copy link, Move, Delete, then the drag handle.
Copy link, which changes nothing, sat between actions that do; the rarely used Promote led the
strip where the most used action, Edit, belongs; and the handle, which is grabbed rather than
clicked, followed Delete with nothing between them.

The strip now runs Copy link, Edit, Promote, Move, Delete: the one action that leaves the row
as it is first, then the two that change it in place, then the two that take it out of the
listing, with Delete last. The main row keeps its pin as the indicator beside the title. The
overflow menu follows the same order, and the drag handle stands a little apart from the buttons.

Considered, omitted: moving the drag handle to the row's left edge, the wider list convention,
which would put it beside the expand chevron and the main row's pin.

AI-authored — Claude Code, Fable 5.1 (max); one-line ask from @JeroenDeDauw after an in-session ordering discussion, no revisions; diff not yet human-reviewed; two order tests written first and seen failing, SubjectsManagerPage spec, eslint, stylelint and build run locally, both rows checked in the dev wiki, CI pending.

JeroenDeDauw and others added 2 commits September 7, 2026 18:05
Follows-up to #1356

The Data tab's row actions ran Promote, Edit, Copy link, Move, Delete, then the drag handle.
Copy link, which changes nothing, sat between actions that do; the rarely used Promote led the
strip where the most used action, Edit, belongs; and the handle, which is grabbed rather than
clicked, followed Delete with nothing between them.

The strip now runs Copy link, Edit, Promote, Move, Delete: the one action that leaves the row
as it is first, then the two that change it in place, then the two that take it out of the
listing, with Delete last. The main row keeps its pin as the indicator beside the title. The
overflow menu follows the same order, and the drag handle stands a little apart from the buttons.

Considered, omitted: moving the drag handle to the row's left edge, the wider list convention,
which would put it beside the expand chevron and the main row's pin.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The two order tests arrived in a describe of their own with a copy of the move-action block's
setup, and left the two move-before-delete tests they subsume in place. They now sit in that
block, and the subsumed tests are gone.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@JeroenDeDauw
JeroenDeDauw marked this pull request as ready for review September 7, 2026 16:11
@JeroenDeDauw
JeroenDeDauw merged commit 73957f6 into master Sep 7, 2026
6 checks passed
@JeroenDeDauw
JeroenDeDauw deleted the feature/row-action-order branch September 7, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant