Order the row actions by what they do to the row - #1366
Merged
Conversation
Follows-up to #1356 The Data tab's row actions ran Promote, Edit, Copy link, Move, Delete, then the drag handle. Copy link, which changes nothing, sat between actions that do; the rarely used Promote led the strip where the most used action, Edit, belongs; and the handle, which is grabbed rather than clicked, followed Delete with nothing between them. The strip now runs Copy link, Edit, Promote, Move, Delete: the one action that leaves the row as it is first, then the two that change it in place, then the two that take it out of the listing, with Delete last. The main row keeps its pin as the indicator beside the title. The overflow menu follows the same order, and the drag handle stands a little apart from the buttons. Considered, omitted: moving the drag handle to the row's left edge, the wider list convention, which would put it beside the expand chevron and the main row's pin. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The two order tests arrived in a describe of their own with a copy of the move-action block's setup, and left the two move-before-delete tests they subsume in place. They now sit in that block, and the subsumed tests are gone. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows-up to #1356
The Data tab's row actions ran Promote, Edit, Copy link, Move, Delete, then the drag handle.
Copy link, which changes nothing, sat between actions that do; the rarely used Promote led the
strip where the most used action, Edit, belongs; and the handle, which is grabbed rather than
clicked, followed Delete with nothing between them.
The strip now runs Copy link, Edit, Promote, Move, Delete: the one action that leaves the row
as it is first, then the two that change it in place, then the two that take it out of the
listing, with Delete last. The main row keeps its pin as the indicator beside the title. The
overflow menu follows the same order, and the drag handle stands a little apart from the buttons.
Considered, omitted: moving the drag handle to the row's left edge, the wider list convention,
which would put it beside the expand chevron and the main row's pin.