Annotation bugfix and extra heatmap #253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I agree with those changes. Seen the bugs firsthand and think they should be included. |
Member
|
I don't want to become nazi again, but I kinda do. Could you separate your commits to reflect the bug fixes. Also ahve a commit message that explains what was wrong (why was the change necessary and why the way you implemented it) Otherwise I'm sure your code is correct. |
Member
|
Please do this since I want to merge your code |
This heatmap indicates the places where the graphs differ
Jumping to an annotation was based on the graph position, while the jump algorithm jumps to the position in the reference genome.
Now annotations are only moved down if there otherwise would be overlap.
FarisElghlan
force-pushed
the
bug/minor-bugs
branch
from
0258f3e to
de01530
Compare
Member
|
Thanks, merging |
Collaborator
Author
|
... |
Collaborator
Author
|
? |
Member
|
Sorry, waiting for checks but then had to travel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some small bugs before the presentation