Fix ajax request callbacks - #276
Merged
Merged
Conversation
Contributor
|
Test merged PR on Playground |
jdevalk
approved these changes
Feb 18, 2025
Member
|
I'll let @aristath review too, but this looks good to me. |
aristath
approved these changes
Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
We do AJAX requests from one function, to which we pass data, URL, success and fail callbacks.
In that function we're registering new callback on the
http.onreadystatechangeevent, success callback was executing fine but fail callback was triggered on every state change - mainly on when http.readyState values were 2 & 3 (headers received & response downloading), which is wrong.I have changed it so fail callback is triggered only when request is done, but response code is not 200.
I noticed this while working on new Onboarding flow, scanning posts was triggered twice and there were multiple
'Failed to scan posts. Retrying...'messages in the console, which looked suspicious.Summary
This PR can be summarized in the following changelog entry:
Quality assurance