Compatibility tweak for SQLite - #380
Merged
Merged
Conversation
Contributor
|
Test merged PR on Playground |
ilicfilip
approved these changes
Mar 26, 2025
ilicfilip
left a comment
ilicfilip
left a comment
Collaborator
There was a problem hiding this comment.
I haven't tested, but as far as I know this is the way SQLite columns are modified 👍
Member
|
LGTM, so let's fix like this for now. The bigger question I have is whether we shouldn't be fixing this in the SQLite integration instead of here... |
Member
Author
Yes, we should. The problem is that I don't know how... In the past few months they have completely changed the parser, and I have no idea what to make of it, I haven't had time to dive into it yet 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQLite doesn't support
MODIFY.This PR changes the db upgrade routine to add compatibility for that scenario