Tell PHPStan which method returns which object - #383
Merged
Conversation
Contributor
|
Test merged PR on Playground |
aristath
approved these changes
Mar 27, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Earlier today we had a fatal PHP error, it was caused by a method being removed on a branch which was merged into develop. A bit later other branch, which used the removed method, was also merged into develop but the method in question was missed (quite easily since we had so many changes).
The problem is that PHP error was triggered in a very specific use case, when plugin was updated, so it wasn't obvious.
But we have tests in place, so how did PHPStan miss it?
Because we use magic methods to get object, so PHPStan doesn't know which object to expect when do
\progress_planner()->get_suggested_tasks()->get_tasks_by_status( 'pending' );This PR adds
@methodannotations which tell PHPStan which methods to expect.Since we're close to release I haven't added annotations for all classes, some of them require PHPStan fixes and I don't want to do that a day before the release.
The objects which we use most often are covered, most importantly
\Progress_Planner\Suggested_Tasksand PHPStan errors and warnings for it are fixed.I also tried implementing a more elegant approach, by defining a
Dynamic Return Type Extensions, but it consumed too much memory and it was pretty slow.Quality assurance