Alternative (better) lock when adding new tasks - #602
Merged
Conversation
Contributor
|
Test on Playground |
ilicfilip
marked this pull request as ready for review
September 17, 2025 11:21
aristath
reviewed
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves fix for the issue described in #515
Very rare but I am still getting duplicated tasks sometimes, most of the time it was "Perform all updates", so the initial fix needs to be improved.
Previously transient was used to make sure lock expires, but the downside is that below the hood
set_transientusesupdate_optionwhich is not good enough. Now theset_transientis replaced withadd_option, which prevents duplicates (I have both checked the Core code and made tests) so finally adding duplicates should be prevented.