Security: update WPCS to 3.4.1 - #768
Merged
Merged
Conversation
Updates wp-coding-standards/wpcs to 3.4.1, which fixes a security issue in the WordPress.WP.EnqueuedResourceParameters sniff where running PHPCS over untrusted PHP code could lead to arbitrary command execution on the scanning host (GHSA-3pwp-g2mj-5p3v). Also bumps the required transitive dependencies: - phpcsstandards/phpcsutils to 1.2.3 - phpcsstandards/phpcsextra to 1.5.1 Lock-file only; composer.json constraints already allowed 3.4.1. Verified locally with PHPCS: no new violations. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Filip Ilic <ilic.filip@gmail.com>
Contributor
|
Test merged PR on Playground |
Contributor
Composer package changes
|
Contributor
✅ Code Coverage Report
🎉 Great job maintaining/improving code coverage! ℹ️ About this report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Updates
wp-coding-standards/wpcsto 3.4.1, plus the transitive bumps it requires:wp-coding-standards/wpcsphpcsstandards/phpcsutilsphpcsstandards/phpcsextraWhy
WPCS 3.4.1 is a security release. Running the
WordPress.WP.EnqueuedResourceParameterssniff over untrusted PHP — e.g. linting a pull request in CI — could lead to arbitrary command execution on the scanning host.Affects the
WordPressandWordPress-Extrarulesets, both of which this repo uses.WordPress-CoreandWordPress-Docsare unaffected.Scope
composer.lockonly. Thecomposer.jsonconstraint already permitted 3.4.1 — CI was installing from the lock file, so it kept resolving to the old version. No workflow or config changes.Verification
PHPCS was run locally before and after the bump and the findings were diffed: no new violations.
🤖 Generated with Claude Code