Add pyproject packaging and GUI CLI entrypoint - #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PySide6) and the language runtime (choomlang).apps/guiso source can be discovered bysetuptoolswithout moving code.Description
pyproject.tomlusingsetuptools.build_metawith project metadata (name,version,description,requires-python).dependenciesincludingPySide6andchoomlang, and register a console scriptimagechoom = imagechoom_gui.cli:mainunder[project.scripts].setuptoolspackage discovery to map the top-level package directory toapps/guiand findimagechoom_gui*packages.apps/gui/imagechoom_gui/__init__.py(defines__version__) andapps/gui/imagechoom_gui/cli.py(implementsmain()that creates and runs a QtQApplicationwith a simpleQLabel).Testing
python -m pip install -e . --no-depsattempted but failed due to environment network/proxy restrictions when pip tried to fetch build dependencies (unable to obtainsetuptools>=68).python -m pip install -e . --no-deps --no-build-isolationsucceeded and produced an editable wheel forimagechoom.command -v imagechoomsucceeded and the console script entry point was registered as shown byimportlib.metadata(entry pointimagechoom = imagechoom_gui.cli:main).python -c "import imagechoom_gui; print(imagechoom_gui.__version__)"succeeded, whilepython -c "import imagechoom_gui, imagechoom_gui.cli"failed in this environment becausePySide6is not installed (runtime dependency not present in the test environment).Codex Task