merge #4
Merged
merge #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses a macro to ADD_SIGNAL and track the data types associated with
each EVREventType in a single action, preventing any risk of signals
getting out of sync with handled events as more are added by Valve.
The OpenVREventHandler is only ever intended to be used as the parent
class of the autoload singleton. This allows the macro magic to be used
for generating signal names instead of having to manually define them in
GDScript. There should also only ever be one handler, and the interface
for hooking it to openvr_data reflects this.
Each macro call includes an extra parameter that is only intended to be
used as developer reference for the source of documentation about which
data type a signal uses. This is generally not documented within the
openvr headers, and often comes from replies to issues on github or
similar. Some of them are educated guesses, and patches with more
definitive information are very welcome.
Signals for events that will never be sent to a client app are not
registered.
Since Valve may release new versions of openvr at any time and we may
not immediately be ready to cut a new godot_openvr release, the method
`register_event_signal` is provided. When new events appear in later
releases of OpenVR, they tend to have an existing data type. This allows
users of the extension to register signals for these new events instead
of having to wait for a new release of godot_openvr to take advantage of
them. For example:
OpenVRInterface.register_event_signal(
539, OpenVREventHandler.Overlay, "OverlayCreated")
OpenVRInterface.connect("OverlayCreated", print)
This could also be used to add signals for events in the vendor-specific
space starting at ID 10000.
Overlay-specific events are received on the appropriate
OpenVROverlayContainer automatically. Overlays do not receive global
events even though this is how it works on the OpenVR level, as this
would lead to events being received multiple times.
Finally, OpenVR is updated to 2.5.1 to pick up several new events. The
demo also now has a HUD which displays a few vrevents to serve as a
basic test.
Expose VREvents as Godot signals
Update library feature tag to x86_64 to match Godot defaults
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.