Don't accidentally reuse overlay keys #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When multiple overlays exist and any but the last is deleted, they shift backward in the array. When another one is then created, it will then try to use the key of an existing one, since those aren't updated to match the new array index. This will cause VROverlayError_KeyInUse, which is promptly ignored, and the overlay container will think it is overlay 0, causing it to start drawing its subviewport texture to the wrong overlay handle. After a few cycles, the world falls apart and overlays don't appear at all anymore. This fixes the problem by just guaranteeing the ID is unique using the overlay container's instance ID. I would like to do further cleanup of the tracking in ovr_data later.
Don't accidentally reuse overlay keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.